On Thu, Oct 2, 2014 at 7:25 AM, Kirill A. Shutemov <kir...@shutemov.name> wrote: > > I don't see what prevents the code to make zero page writable here. > We need at least pmd = pmd_wrprotect(pmd) before set_pmd_at();
Do we? If it's the zero page, it had better be an anonymous mapping, and vm_page_prot had better not be writable. Anonymous pages don't _start_ out writable, we explicitly make them so with code like if (vma->vm_flags & VM_WRITE) entry = pte_mkwrite(pte_mkdirty(entry)); so it should be fine to just use "pmd_modify(pmd, vma->vm_page_prot);" directly. But hey, this is the kind of thing that maybe I'm missing something on.. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/