From: Michael Welling <mwell...@ieee.org> Date: Fri, 3 Oct 2014 15:43:59 -0500
> On Fri, Oct 03, 2014 at 01:03:05PM -0700, David Miller wrote: >> From: Michael Welling <mwell...@ieee.org> >> Date: Wed, 1 Oct 2014 21:32:05 -0500 >> >> > The code currently checks the mac_addr variable that is clearly >> > zero'd out during allocation. >> > >> > Further code is added to bring the mac_addr from the partial pdata. >> > >> > Signed-off-by: Michael Welling <mwell...@ieee.org> >> >> I don't see anyone specifying a MAC address in the partial pdata, >> so better to just delete that field. >> >> Even if people did, I am not so sure that the partial pdata should >> unconditionally trump an OF provided MAC address. > > So should I just leave the code for handling the mac_addr field from the > partial pdata out or make it such that the mac_addr field is overriden > if specified from the devicetree? I'm saying the partial pdata mac_addr is completely unused and should be removed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
