> -----Original Message----- > From: Francois Romieu [mailto:[email protected]] > Sent: Tuesday, October 07, 2014 6:13 AM > To: Hau > Cc: [email protected]; nic_swsd; [email protected] > Subject: Re: [PATCH v2 net-next] r8169:add support for RTL8168EP > > Hau <[email protected]> : > [...] > > Do you mean I should collect similar hardware parameters setting into > > one function ? or I should set hardware parameters according to > > hardware feature support version? > > static void r8168dp_ocp_write(...) > [...] > > static void r8168ep_ocp_write(...) > [...] > > static void ocp_write(...) > { > switch (... > case ... > r8168dp_ocp_write > > case ... > r8168ep_ocp_write > [...] > > static void rtl8168dp_driver_start(...) > [...] > > static void rtl8168ep_driver_start(...) > [...] > > etc. > > Nothing more. At some point the helpers themselves may turn into data > struct members. Things don't need to be immediately right - if ever. > However you really want to avoid unrelated changes in your patches: > shuffling code and changing features at the same time hurts reviews, late > regression hunts, backports, etc. > > -- > Ueimor >
Thanks, I will do that on later patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
