From: Joe Perches <j...@perches.com>

Use print_hex_dump_bytes instead of pr_info

Signed-off-by: Dzmitry Sledneu <dzmitry.sled...@gmail.com>
Reviewed-by: Insop Song <insop.s...@gainspeed.com>

---
 drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 25 ++-----------------------
 1 file changed, 2 insertions(+), 23 deletions(-)

diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c 
b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
index 6aa9d7c..9764a9a 100644
--- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
+++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
@@ -46,27 +46,6 @@ static char  *file = "xlinx_fpga_firmware.bit";
 module_param(file, charp, S_IRUGO);
 MODULE_PARM_DESC(file, "Xilinx FPGA firmware file.");
 
-#ifdef DEBUG_FPGA
-static void datadump(char *msg, void *m, int n)
-{
-       int i;
-       unsigned char *c;
-
-       pr_info("=== %s ===\n", msg);
-
-       c = m;
-
-       for (i = 0; i < n; i++) {
-               if ((i&0xf) == 0)
-                       pr_info(KERN_INFO "\n  0x%4x: ", i);
-
-               pr_info("%02X ", c[i]);
-       }
-
-       pr_info("\n");
-}
-#endif /* DEBUG_FPGA */
-
 static void read_bitstream(char *bitdata, char *buf, int *offset, int rdsize)
 {
        memcpy(buf, bitdata + *offset, rdsize);
@@ -220,9 +199,9 @@ static int gs_download_image(struct fpgaimage *fimage, enum 
wbus bus_bytes)
        size = fimage->lendata;
 
 #ifdef DEBUG_FPGA
-       datadump("bitfile sample", bitdata, 0x100);
+       print_hex_dump_bytes("bitfile sample: ", DUMP_PREFIX_OFFSET,
+                            bitdata, 0x100);
 #endif /* DEBUG_FPGA */
-
        if (!xl_supported_prog_bus_width(bus_bytes)) {
                pr_err("unsupported program bus width %d\n",
                                bus_bytes);
-- 
2.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to