Now when I did the patch again I just want to ensure that this is not any other 
errors.

Although strncpy use before was wrong, it did filled the remaining part of the 
string with null
characters. This is not something that is needed?


And a part that is not obvious right, so check.
When brcmf_firmware_path[0] == '\0'   we do not want to do like.

if (brcmf_firmware_path[0] != '\0') {
...
} else {
  sdiodev->fw_name[0] = '\0';
  sdiodev->nvram_name[0] = '\0';
}


Kind regards
Rickard Strandqvist


Rickard Strandqvist (1):
  net: wireless: brcm80211: brcmfmac: dhd_sdio.c:  Cleaning up missing 
null-terminate in conjunction with
    strncpy

 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c |   25 ++++++++++----------
 1 file changed, 12 insertions(+), 13 deletions(-)

-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to