On Mon, Sep 29, 2014 at 02:42:18PM +0200, Krzysztof Kozlowski wrote: > The pl330_submit_req() checked supplied 'struct pl330_thread thrd' and > 'struct dma_pl330_desc desc' parameters for non-NULL. However these > checks are useless because supplied arguments won't be NULL. even if we have some error or bug?
I would like this to be checked and complained loudly so we know something is going wrong rather than assuming it will be correct always. -- ~Vinod > > The pl330_submit_req() is called in only one place and: > 1. 'desc' is already dereferenced in fill_queue() before calling > pl330_submit_req(). > 2. 'thrd' is always dereferenced after calling > fill_queue()->pl330_submit_req(). > > Removing the checks for non-NULL values fixes following warning: > drivers/dma/pl330.c:1376 pl330_submit_req() warn: variable dereferenced > before check 'thrd' (see line 1367) > > Signed-off-by: Krzysztof Kozlowski <[email protected]> > > --- > > Changes since v1: > ================= > 1. Remove the checks for non-NULL completely instead of moving them > before dereference. Suggested by Lars-Peter Clausen. > --- > drivers/dma/pl330.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index d5149aacd2fe..57049f84d0c0 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -1372,10 +1372,6 @@ static int pl330_submit_req(struct pl330_thread *thrd, > u32 ccr; > int ret = 0; > > - /* No Req or Unacquired Channel or DMAC */ > - if (!desc || !thrd || thrd->free) > - return -EINVAL; > - > regs = thrd->dmac->base; > > if (pl330->state == DYING > -- > 1.9.1 > -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
