On wto, 2014-10-14 at 17:21 +0530, Vinod Koul wrote: > On Mon, Sep 29, 2014 at 02:42:18PM +0200, Krzysztof Kozlowski wrote: > > The pl330_submit_req() checked supplied 'struct pl330_thread thrd' and > > 'struct dma_pl330_desc desc' parameters for non-NULL. However these > > checks are useless because supplied arguments won't be NULL. > even if we have some error or bug? > > I would like this to be checked and complained loudly so we know something > is going wrong rather than assuming it will be correct always.
Currently the driver would fail before or after, regardless of this check. However I do not insist on this approach. The first version of patch was little different: https://lkml.org/lkml/2014/9/5/390 Do you think that 1st version is worth resending? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
