* Bjorn Helgaas <[email protected]> wrote: > For the following interfaces: > > get_penwell_ops() > get_cloverview_ops() > get_tangier_ops() > > there is only one implementation, so they do not need to be marked "weak". > > Remove the "weak" attribute from their declarations. > > Signed-off-by: Bjorn Helgaas <[email protected]> > CC: David Cohen <[email protected]> > CC: Kuppuswamy Sathyanarayanan <[email protected]> > CC: [email protected] > --- > arch/x86/platform/intel-mid/intel_mid_weak_decls.h | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/platform/intel-mid/intel_mid_weak_decls.h > b/arch/x86/platform/intel-mid/intel_mid_weak_decls.h > index 46aa25c8ce06..3c1c3866d82b 100644 > --- a/arch/x86/platform/intel-mid/intel_mid_weak_decls.h > +++ b/arch/x86/platform/intel-mid/intel_mid_weak_decls.h > @@ -10,10 +10,9 @@ > */ > > > -/* __attribute__((weak)) makes these declarations overridable */ > /* For every CPU addition a new get_<cpuname>_ops interface needs > * to be added. > */ > -extern void *get_penwell_ops(void) __attribute__((weak)); > -extern void *get_cloverview_ops(void) __attribute__((weak)); > -extern void *get_tangier_ops(void) __attribute__((weak)); > +extern void *get_penwell_ops(void); > +extern void *get_cloverview_ops(void); > +extern void *get_tangier_ops(void);
Acked-by: Ingo Molnar <[email protected]> Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

