On October 18, 2014 3:19:50 PM CDT, Davidlohr Bueso <d...@stgolabs.net> wrote: >On Sat, 2014-10-18 at 14:32 -0500, Darren Hart wrote: >> Which is not incomplete (lacking the explicit smp_mb()) added by this >> patch. Perhaps the MB implementation of get_futex_key_refs() need not >be >> explicitly enumerated here? > >Agreed, how about this: > >diff --git a/kernel/futex.c b/kernel/futex.c >index 21f7e41..7a0805a 100644 >--- a/kernel/futex.c >+++ b/kernel/futex.c >@@ -143,9 +143,8 @@ > * >* Where (A) orders the waiters increment and the futex value read >through >* atomic operations (see hb_waiters_inc) and where (B) orders the write >- * to futex and the waiters read -- this is done by the barriers in >- * get_futex_key_refs(), through either ihold or atomic_inc, depending >on the >- * futex type. >+ * to futex and the waiters read -- this is done by the barriers for >both >+ * shared and private futexes in get_futex_key_refs().
Works for me. -- Sent from my Android device with K-9 Mail. Please excuse my brevity. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
