On Tue, Oct 14, 2014 at 01:53:44PM -0700, [email protected] wrote: > > The patch titled > Subject: mm/compaction.c: avoid premature range skip in > isolate_migratepages_range > has been added to the -mm tree. Its filename is > > mm-compaction-avoid-premature-range-skip-in-isolate_migratepages_range.patch > > This patch should soon appear at > > http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-avoid-premature-range-skip-in-isolate_migratepages_range.patch > and later at > > http://ozlabs.org/~akpm/mmotm/broken-out/mm-compaction-avoid-premature-range-skip-in-isolate_migratepages_range.patch > > Before you just go and hit "reply", please: > a) Consider who else should be cc'ed > b) Prefer to cc a suitable mailing list as well > c) Ideally: find the original patch on the mailing list and do a > reply-to-all to that, adding suitable additional cc's > > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > The -mm tree is included into linux-next and is updated > there every 3-4 working days > > ------------------------------------------------------ > From: Joonsoo Kim <[email protected]> > Subject: mm/compaction.c: avoid premature range skip in > isolate_migratepages_range > > commit edc2ca612496 ("mm, compaction: move pageblock checks up from > isolate_migratepages_range()") commonizes isolate_migratepages variants > and make them use isolate_migratepages_block(). > > isolate_migratepages_block() could stop the execution when enough pages > are isolated, but, there is no code in isolate_migratepages_range() to > handle this case. In the result, even if isolate_migratepages_block() > returns prematurely without checking all pages in the range, > > isolate_migratepages_block() is called repeately on the following > pageblock and some pages in the previous range are skipped to check. > Then, CMA is failed frequently due to this fact. > > To fix this problem, this patch let isolate_migratepages_range() know the > situation that enough pages are isolated and stop the isolation in that > case. > > Note that isolate_migratepages() has no such problem, because, it always > stops the isolation after just one call of isolate_migratepages_block(). > > Signed-off-by: Joonsoo Kim <[email protected]> > Cc: Vlastimil Babka <[email protected]> > Cc: David Rientjes <[email protected]> > Cc: Minchan Kim <[email protected]> > Cc: Michal Nazarewicz <[email protected]> > Cc: Naoya Horiguchi <[email protected]> > Cc: Christoph Lameter <[email protected]> > Cc: Rik van Riel <[email protected]> > Cc: Mel Gorman <[email protected]> > Cc: Zhang Yanfei <[email protected]> > Signed-off-by: Andrew Morton <[email protected]>
Hello, Andrew. I forgot to mention that this should be merged for v3.18. :) Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
