On Wed 2014-10-22 16:43:10, Kees Cook wrote: > On Wed, Oct 22, 2014 at 4:26 PM, Andrew Morton > <a...@linux-foundation.org> wrote: > > On Tue, 21 Oct 2014 13:21:37 -0700 Kees Cook <keesc...@chromium.org> wrote: > > > >> From: Paul Wise <pa...@bonedaddy.net> > >> > >> This partially mitigates a common strategy used by attackers for hiding > >> the full contents of strings in procfs from naive sysadmins who use cat, > >> more or sysctl to inspect the contents of strings in procfs. > >> > >> ... > >> > >> --- a/kernel/sysctl.c > >> +++ b/kernel/sysctl.c > >> @@ -1739,7 +1739,7 @@ static int _proc_do_string(char *data, int maxlen, > >> int write, > >> while ((p - buffer) < *lenp && len < maxlen - 1) { > >> if (get_user(c, p++)) > >> return -EFAULT; > >> - if (c == 0 || c == '\n') > >> + if (c == 0 || c == '\n' || c == '\r') > >> break; > >> data[len++] = c; > >> } > > > > There are no valid uses of \r in a procfs write? > > I struggle to imagine one; everything I found that uses proc_dostring > seems to be names, paths, and commands.
Well, filename can contain \r, right? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/