On Wed, Oct 29, 2014 at 06:23:02PM +0800, Junjie Mao wrote: > I was not familiar with the acquiring/releasing API either, until I met > with this bug... > > Perhaps we can use static checkers to avoid these issues as early as > possible. Any suggestions?
CC Dan. His smatch checker might be able (or could be enabled) to handle the verification of missing device_release_driver() call. Thanks, Fengguang > Martin Pitt <martin.p...@ubuntu.com> writes: > > > Acked-By: Martin Pitt <martin.p...@ubuntu.com> > > > > Hello Junjie, > > > > Junjie Mao [2014-10-28 9:31 +0800]: > >> The driver is not released when ieee80211_register_hw fails in > >> mac80211_hwsim_create_radio, leading to the access to the unregistered (and > >> possibly freed) device in platform_driver_unregister: > > > > Many thanks for fixing this! Sorry about that, I don't know these bits > > very well. > > > > Martin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
