On Mon, Nov 03, 2014 at 12:16:34AM +0000, Al Viro wrote: > > NAK with extreme prejudice. The right way to deal with that is > to convert the socket side of things to iov_iter. And give it a > consistent behaviour, while we are at it (some protocols do advance > the damn thing, so do not). There are _very_ good reasons to have those > iovecs unchanged - if you look at the callers on the socket side, you'll > see a bunch that has to _copy_ iovec just to avoid it being buggered. > And you get rather suboptimal behaviour in memcpy_fromiovec() and friends, > exactly because you have to skip through the emptied elements. > > IOW, no way in hell.
You're welcome to send patches fix every spot in the network stack that writes to the iovec. But until the network stack is all fixed up, having a const struct iovec in aio_read/aio_write is a delusion. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
