On Tue, Nov 04, 2014 at 02:32:00PM +0000, Al Viro wrote: > On Tue, Nov 04, 2014 at 04:31:34PM +0800, Herbert Xu wrote: > > This patch adds skb_copy_datagram_iter, which is identical to > > skb_copy_datagram_iovec except that it operates on iov_iter > > instead of iovec. > > > > Eventually all users of skb_copy_datagram_iovec should switch > > over to iov_iter and then we can remove skb_copy_datagram_iovec. > > Too noisy, IMO. How about skb_copy_datagram_msg() first? The fewer > places have to even think of iovec or iov_iter, the better...
PS: "too noisy" is about turning every callsite of skb_copy_datagram_iovec into that of skb_copy_datagram_iter; the helper itself is just fine. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
