On 10/30/2014 05:51 PM, Mark Brown wrote:
On Thu, Oct 30, 2014 at 12:26:55PM +0100, Mike Looijmans wrote:
+       np = of_node_get(i2c->dev.of_node);
+       np_regulators = of_get_child_by_name(np, "regulators");

+               np_child = of_get_child_by_name(np_regulators,
+                       ltc3562_regulators[i].name);
+               if (np_child == NULL) {

Use the core support for looking up constraints please - set
regulators_node and so on.

I've been reworking the driver, but this is the only feedback comment I didn't quite understand. What is it that I'm expected to do here? Probably just the name of the method I'm supposed to call here would be enough.


The rest of your feedback I've processed and tested the results.

Mike.


Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Systems
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: (+31) (0) 499 33 69 79
Telefax:  (+31) (0) 499 33 69 70
E-mail: mike.looijm...@topic.nl
Website: www.topic.nl

Please consider the environment before printing this e-mail

Topic zoekt gedreven (embedded) software specialisten!
http://topic.nl/vacatures/topic-zoekt-software-engineers/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to