On Sun, 26 Oct 2014, Joe Perches wrote: > Precedence of & and >> is not the same and is not left to right. > shift has higher precedence and should be done after the mask. > > Add parentheses around the mask. > > Signed-off-by: Joe Perches <j...@perches.com> > --- > drivers/mfd/wm8350-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Applied with Charles' Ack. > diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c > index 4ab527f..f5124a8 100644 > --- a/drivers/mfd/wm8350-core.c > +++ b/drivers/mfd/wm8350-core.c > @@ -308,7 +308,7 @@ int wm8350_device_init(struct wm8350 *wm8350, int irq, > goto err; > } > > - mode = id2 & WM8350_CONF_STS_MASK >> 10; > + mode = (id2 & WM8350_CONF_STS_MASK) >> 10; > cust_id = id2 & WM8350_CUST_ID_MASK; > chip_rev = (id2 & WM8350_CHIP_REV_MASK) >> 12; > dev_info(wm8350->dev, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
