Milosz Tanski <mil...@adfin.com> writes: > - if (type == READ && (flags & RWF_NONBLOCK)) > - return -EAGAIN; > + if (type == READ) { > + if (flags & RWF_NONBLOCK) > + return -EAGAIN; > + } else { > + if (flags & RWF_DSYNC) > + return -EINVAL; > + }
Minor nit, but I'd rather read something that looks like this: if (type == READ && (flags & RWF_NONBLOCK)) return -EAGAIN; else if (type == WRITE && (flags & RWF_DSYNC)) return -EINVAL; I won't lose sleep over it, though. Reviewed-by: Jeff Moyer <jmo...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/