On 21 October 2014 03:09, Josh Boyer <[email protected]> wrote: > On Mon, Oct 20, 2014 at 10:05 AM, Michael S. Tsirkin <[email protected]> wrote: >> On Mon, Oct 20, 2014 at 03:58:49PM +0200, Cornelia Huck wrote: >>> Commit f5866db6 (virtio_console: enable VQs early) tried to make >>> sure that DRIVER_OK was set when virtio_console started using its >>> virtqueues. Doing this in add_port(), however, means that we try >>> to set DRIVER_OK again when when a port is dynamically added after >>> the probe function is done. >>> >>> Let's move virtio_device_ready() to the probe function just before >>> trying to use the virtqueues instead. This is fine as nothing can >>> fail inbetween. >>> >>> Reported-by: Thomas Graf <[email protected]> >>> Reviewed-by: Michael S. Tsirkin <[email protected]> >>> Signed-off-by: Cornelia Huck <[email protected]> >> >> Thanks! >> >> Acked-by: Michael S. Tsirkin <[email protected]> >> Tested-by: Michael S. Tsirkin <[email protected]> > > This fixed my KVM guest boot issue with 3.18-rc1. Thanks for such a quick > fix. > > Tested-by: Josh Boyer <[email protected]>
ping So who's merging this? Rusty? still happens in -rc4. Dave. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

