Hi Lee, Thanks for reviewing.
On Mon, 10 Nov 2014, Lee Jones wrote: > > + reg = <0xf8 0x04>, /* syscfg 5062 */ > > + <0xf4 0x04>; /* syscfg 5061 */ > > Are there really only 2 32bit registers to control this h/w? Yes > > > + reg-names = "param", > > + "ctrl"; > > Superflous indentation after 'reg = ' and 'reg-names = '. Fixed in v2. > > + st,syscfg = <&syscfg_core>; > > + resets = <&softreset STIH407_PICOPHY_SOFTRESET>, > > + <&picophyreset STIH407_PICOPHY0_RESET>; > > + reset-names = "global", > > + "port"; > > May as well put these on the same line. Fixed in v2. regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
