> > From: Pankaj Gupta <[email protected]> > Date: Tue, 25 Nov 2014 00:04:04 +0530 > > > This patch switches to flex array to implement the flow caches, it brings > > several advantages: > > > > - Reduce the size of the tun_struct structure, which allows us to increase > > the > > upper limit of queues in future. > > - Avoid higher order memory allocation. It will be useful when switching to > > pure hashing in flow cache which may demand a larger size array in > > future. > > > > After this patch, the size of tun_struct on x86_64 reduced from 8512 to > > 328 > > > > Signed-off-by: Jason Wang <[email protected]> > > Signed-off-by: Pankaj Gupta <[email protected]> > > Reviewed-by: David Gibson <[email protected]> > > I see no reason to use flex arrays for this, you are preallocaing the > memory so if anything flex array is adding an unnecessary level of > redirection for every access in return for no real gains. > > Just allocate the thing normally using kzalloc() or whatever.
I agree. Will do the changes and submit v3. > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
