Em Wed, Nov 26, 2014 at 04:39:31PM +0100, Jiri Olsa escreveu: > Linus reported perf report command being interrupted due to > processing of 'out of order' event, with following error: > > Timestamp below last timeslice flush > 0x5733a8 [0x28]: failed to process type: 3 > > I could reproduce the issue and in my case it was caused by one > CPU (mmap) being behind during record and userspace mmap reader > seeing the data after other CPUs data were already stored. > > It'd be nice to find the source of this hiccup, meanwhile I'm > submitting change that does not kill the processing, but only > tracks the number of out of order events and warn user.
Works, for me, thanks for the fast response! - Arnaldo > Reported-by: Linus Torvalds <[email protected]> > Cc: Linus Torvalds <[email protected]> > Cc: Andi Kleen <[email protected]> > Cc: Corey Ashford <[email protected]> > Cc: David Ahern <[email protected]> > Cc: Frederic Weisbecker <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Matt Fleming <[email protected]> > Cc: Namhyung Kim <[email protected]> > Cc: Paul Mackerras <[email protected]> > Cc: Peter Zijlstra <[email protected]> > Cc: Stephane Eranian <[email protected]> > Cc: Arnaldo Carvalho de Melo <[email protected]> > Signed-off-by: Jiri Olsa <[email protected]> > --- > tools/perf/util/event.h | 1 + > tools/perf/util/session.c | 13 +++++++------ > 2 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h > index 09b9e8d3fcf7..c4ffe2bd0738 100644 > --- a/tools/perf/util/event.h > +++ b/tools/perf/util/event.h > @@ -242,6 +242,7 @@ struct events_stats { > u32 nr_invalid_chains; > u32 nr_unknown_id; > u32 nr_unprocessable_samples; > + u32 nr_unordered_events; > }; > > struct attr_event { > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c > index 6ac62ae6b8fa..17a85f527bfc 100644 > --- a/tools/perf/util/session.c > +++ b/tools/perf/util/session.c > @@ -533,15 +533,11 @@ int perf_session_queue_event(struct perf_session *s, > union perf_event *event, > return -ETIME; > > if (timestamp < oe->last_flush) { > - WARN_ONCE(1, "Timestamp below last timeslice flush\n"); > - > - pr_oe_time(timestamp, "out of order event"); > + pr_oe_time(timestamp, "out of order event\n"); > pr_oe_time(oe->last_flush, "last flush, last_flush_type %d\n", > oe->last_flush_type); > > - /* We could get out of order messages after forced flush. */ > - if (oe->last_flush_type != OE_FLUSH__HALF) > - return -EINVAL; > + s->stats.nr_unordered_events++; > } > > new = ordered_events__new(oe, timestamp, event); > @@ -1118,6 +1114,11 @@ static void perf_session__warn_about_errors(const > struct perf_session *session, > "Do you have a KVM guest running and not using > 'perf kvm'?\n", > session->stats.nr_unprocessable_samples); > } > + > + if (session->stats.nr_unordered_events != 0) { > + ui__warning("%u out of order events recorded.\n", > + session->stats.nr_unordered_events); > + } > } > > volatile int session_done; > -- > 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
