On Sunday 30 November 2014 21:46:39 suravee.suthikulpa...@amd.com wrote:
> From: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com>
>
> AMD Seattle should support 40-bit DMA.
>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com>
>
The change looks good, but two things about the patch description:
- You should be a little more verbose, especially after we had discussed
this to some detail on IRC, explain why you use the specific values.
- You should configure git-send-email to know your full email address
including the name. Right now it gets sent from
"suravee.suthikulpa...@amd.com" instead of "Suravee Suthikulpanit
<suravee.suthikulpa...@amd.com>", and that causes the extra From
line at the start of the mail, besides looking a bit strange.
Thanks,
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
