Hi, On Mon, Dec 1, 2014 at 2:08 PM, Doug Anderson <diand...@chromium.org> wrote: > Hi, > > On Mon, Dec 1, 2014 at 11:51 AM, Kevin Hilman <khil...@kernel.org> wrote: >> Chris Zhong <z...@rock-chips.com> writes: >> >>> devices, since we still lack power_domain driver, so the other power rail >>> of rk3288 need keep power on. >>> I have tested it on rk3288-evb board, atop next-20141112. goto suspend by >>> type >>> "echo mem > /sys/power/state", vdd_cpu is about 0mv by measuring, so it can >>> be >>> determined in sleep mode, then press power button to wakeup it. >> >> I tested this on top of today's linux-next (next-20141201) and it >> suspends, but doesn't wake up from any of the button presses. What >> wakeup sources are configured for the rk3288-evb-rk808? > > Just to close the loop (I talked with Kevin over IM about this, too): > > I have a huge description of how I tested this as part of my patch at > <https://patchwork.kernel.org/patch/5414941/>. Chris: I think Kevin > has asked you several times to include information like this in your > cover letter. Please, please, please can you try to remember to do > this?
Talked to Chris offline. He said that in his tests the other patches weren't needed, so he didn't list any other patches. Things just worked for him. ...so I guess he did post the instructions that worked for him. Sorry for the complaint. Possibly things are different on "next-20141112" and that's where Chris said he tested. I know that I personally needed some of the extra patches. I guess the USB one wasn't truly needed (only needed for hotplug), but for me things were unhappy without SMP. It was hanging when trying to turn off secondary CPUs. I didn't dig, though. The clocksource patches are needed for me because I'm using an old bootloader, but I think they're also relevant for S2R because (I'm told) we can lose the virtual offset at suspend time in certain modes. -Doug . -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/