On Thu, 04 Dec 2014 08:14:01 +0900 Masami Hiramatsu <masami.hiramatsu...@hitachi.com> wrote:
> >> to allow run this on busybox or dash, we'd better clean it. > > > > Do you know how to fix this? > > Yes, it's easy :). > As the tool output, [ a == b ] can be changed to [ a = b ], > and "let ..." can be changed to "$((...))" OK, thanks. > > > > >> > >>> Signed-off-by: Steven Rostedt <rost...@goodmis.org> > >>> --- > >> [...] > >>> +# Test more complex compares (&& and !!) > >>> +test_cmp2 -ne 0 -a -gt 10 "!= 0" "> 10" "&&" '' > >>> +test_cmp2 -ne 0 -o -gt 10 "!= 0" "> 10" "||" '' > >> > >> This might better be > >> test_cmp2 -ne 0 -a -gt 10 "!= 0" "&&" "> 10" '' > >> test_cmp2 -ne 0 -o -gt 10 "!= 0" "||" "> 10" '' > >> > >> :-) > > > > Sure. > > > > OK, I'll hold off on sending this patch then till 3.20. > > OK. > > > > > I'll still add the update to the kernel for 3.19, but the testing for > > it needs work. It passes my test suite, but I don't know how to handle > > the busybox limitations. > > If you are using Fedora, it provides dash and busybox packages too. Yep, and so does Debian. In fact, I notice that my Debian boxes all have /bin/sh linked to dash not bash (which means they were not as susceptible to the bash bug). -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
