On Thu, 04 Dec 2014 19:06:37 +0900 Masami Hiramatsu <masami.hiramatsu...@hitachi.com> wrote:
> Hi Steven, > > I have just one comment. > > (2014/12/04 12:18), Steven Rostedt wrote: > > +# Test more complex compares (&& and !!) > > +test_cmp2 -ne 0 -a -gt 10 "!= 0" "> 10" "&&" '' > > +test_cmp2 -ne 0 -o -gt 10 "!= 0" "> 10" "||" '' > > + > > +test_cmp2 -ne 0 -a -gt 10 "!= 0" "> 10" "&&" '!' > > +test_cmp2 -ne 0 -o -gt 10 "!= 0" "> 10" "||" '!' > > These are not fixed :( Oops, forgot about this. I was so focused on the dash commands I forgot about the easy stuff. > > > + filter1=$6 > > + filter2=$7 > > + fconj=$8 > > are better to be > > > + filter1=$6 > > + fconj=$7 > > + filter2=$8 > > so that we can easily review parameters. > > Others are OK for me. > Yep, I'll make a v3 soon. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
