On 12/12/14 09:31, Joe Perches wrote: > On Fri, 2014-12-12 at 09:25 +0000, Andrew Jackson wrote: >> The devm_XXX allocation functions print a message on failure, >> so additional messages are not required. > [] >> diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c > [] >> @@ -345,26 +345,17 @@ static int dw_i2s_probe(struct platform_device *pdev) >> } >> >> dw_i2s_dai = devm_kzalloc(&pdev->dev, sizeof(*dw_i2s_dai), GFP_KERNEL); >> - if (!dw_i2s_dai) { >> - dev_err(&pdev->dev, "mem allocation failed for dai driver\n"); >> + if (!dw_i2s_dai) >> return -ENOMEM; >> - } > > ok. > >> dw_i2s_dai->ops = &dw_i2s_dai_ops; >> dw_i2s_dai->suspend = dw_i2s_suspend; >> dw_i2s_dai->resume = dw_i2s_resume; >> >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> - if (!res) { >> - dev_err(&pdev->dev, "no i2s resource defined\n"); >> - return -ENODEV; >> - } >> - > > Why delete this?
Lars-Peter said that it was unnecessary: see <http://lists.infradead.org/pipermail/linux-arm-kernel/2014-December/308416.html>. > >> dev->i2s_base = devm_ioremap_resource(&pdev->dev, res); >> - if (IS_ERR(dev->i2s_base)) { >> - dev_err(&pdev->dev, "ioremap fail for i2s_region\n"); >> + if (IS_ERR(dev->i2s_base)) >> return PTR_ERR(dev->i2s_base); >> - } > > or this? Ditto Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/