Hi Ok, if you want, otherwise we can put it after the NULL check?
Kind regards Rickard Strandqvist 2014-12-14 23:52 GMT+01:00 Joe Perches <[email protected]>: > On Sun, 2014-12-14 at 23:42 +0100, Rickard Strandqvist wrote: >> There is otherwise a risk of a possible null pointer dereference. >> Was largely found by using a static code analysis program called cppcheck. > [] >> diff --git a/drivers/staging/vt6655/wmgr.c b/drivers/staging/vt6655/wmgr.c > [] >> @@ -4391,7 +4391,7 @@ bAdd_PMKID_Candidate( >> unsigned int ii = 0; >> >> pr_debug("bAdd_PMKID_Candidate START: (%d)\n", >> - (int)pDevice->gsPMKIDCandidate.NumCandidates); >> + (int)(pDevice ? pDevice->gsPMKIDCandidate.NumCandidates : 0)); > > This is a function tracing printk. > I think it's better to just remove it. > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
