On Thu, Dec 11, 2014 at 09:55:38PM +0000, Strasser, Kevin wrote: Please fix your mailer to word wrap comfortably under 80 colums so that your mails are easily legible.
> > This changes the check from verifying if a codec_id is present to verifying > > if > > the first character in the codec_id is non-NULL. That doesn't seem > > obviously > > safer and the tables of machines seem to be terminated by having an entry > > with all fields set to zero (which is a common idiom in Linux) which would > > now crash with this change. > In this case mach->codec_id is non-NULL, even for the terminating element, > because it > is defined to be a fixed width. So we have to take a look at the first > character to see if it > has been initialized. That's a really unusual and (as you've seen) error prone idiom - is it not better to fix the struct to use the more common idiom?
signature.asc
Description: Digital signature
