On Mon, Jan 05, 2015 at 09:13:47AM -0500, Tejun Heo wrote: > On Fri, Dec 05, 2014 at 11:41:33PM +0100, Rasmus Villemoes wrote: > > Returning a difference from a comparison functions is usually wrong > > (see acbbe6fbb240 "kcmp: fix standard comparison bug" for the long > > story). Here there is the additional twist that if the void pointers > > ns and kn->ns happen to differ by a multiple of 2^32, > > kernfs_name_compare returns 0, falsely reporting a match to the > > caller. > > > > Technically 'hash - kn->hash' is ok since the hashes are restricted to > > 31 bits, but it's better to avoid that subtlety. > > > > Signed-off-by: Rasmus Villemoes <[email protected]> > > Acked-by: Tejun Heo <[email protected]> > > And this is a -stable material. Greg, can you please pick this one > up?
Will do, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
