On Mon, Jan 05, 2015 at 05:55:04PM -0500, Rafael Aquini wrote:
> > > + seq_printf(m, " kernelpagesize_kB=%lu", vma_kernel_pagesize(vma) >> 10);
> > 
> > This changes the format of the numa_maps file and can potentially break
> > existing parsers.  Please discuss.
> > 
> > I'd complain about the patch's failure to update the documentation,
> > except numa_maps appears to be undocumented.  Sigh.  What the heck is "N0"?
> >
> That's a nice opportunity to attempt to sharp my doc writing skills.
> Sorry for the total failure to identify it earlier.
> I just took it as a TODO note to send a patch to document this interface soon.
>

Or perhaps that's a sign we should move the numa node locality
information to /proc/$pid/smaps and start printing a deprecation warning
for /proc/$pid/numa_maps users preparing them for a future removal?

 
> Happy new year.
> -- Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to