On Mon, Jan 12, 2015 at 12:03 PM, Kirill A. Shutemov <kir...@shutemov.name> wrote: > On Mon, Jan 12, 2015 at 10:42:11AM -0800, Andrew Lutomirski wrote: >> On Mon, Jan 12, 2015 at 10:38 AM, Darren Hart <dvh...@infradead.org> wrote: >> > On Mon, Jan 12, 2015 at 12:58:02AM +0200, Kirill A. Shutemov wrote: >> >> On Thu, Dec 18, 2014 at 09:51:27AM -0800, Darren Hart wrote: >> >> > thinkpad-acpi using software mute simplifies the driver and the user >> >> > experience >> >> > significantly. >> >> >> >> Except when it doesn't. >> >> >> >> I'm probably in minority, but I don't use fancy userspace to mess with my >> >> mixer and the mute button worked just fine for me before the change. >> >> Wasted half an hour to find out what happened is not a pure win from user >> >> experience point of view. >> >> >> >> Is it really necessary to have software_mute_requested == true by default? >> >> Can fancy userspace ask for desired behaviour instead and change kernel to >> >> not send hotkeys change notification until software_mute is enabled? >> >> >> >> -- >> >> Kirill A. Shutemov >> >> >> > >> > Thanks for the report Kirill, >> > >> > Andy, we're at RC4, so if we need to fix (or revert) this fix, we only >> > have a >> > couple weeks to do so. >> > >> > Kirill, to define the scope of the problem, if you specify >> > software_mute_requested as false on the kernel command line, does your >> > system >> > function as expected? >> >> If I understood Kirill's email correctly, the only issue is that he >> liked the old behavior. Kirill, is that correct? > > Yes. For now I use thinkpad_acpi.software_mute=0 to get old behaviour. >
What aspect of the old behavior is better than the new default behavior? --Andy > -- > Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/