On Tue 13-01-15 13:59:52, Johannes Weiner wrote: > Turn the move type enum into flags and give the flags field a shorter > name. Once that is done, move_anon() and move_file() are simple > enough to just fold them into the callsites. > > Signed-off-by: Johannes Weiner <[email protected]>
Acked-by: Michal Hocko <[email protected]> one nit below > --- > mm/memcontrol.c | 49 ++++++++++++++++++------------------------------- > 1 file changed, 18 insertions(+), 31 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 5a5769e8b12c..692e96407627 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -360,21 +360,18 @@ static bool memcg_kmem_is_active(struct mem_cgroup > *memcg) > > /* Stuffs for move charges at task migration. */ > /* > - * Types of charges to be moved. "move_charge_at_immitgrate" and > - * "immigrate_flags" are treated as a left-shifted bitmap of these types. > + * Types of charges to be moved. > */ > -enum move_type { > - MOVE_CHARGE_TYPE_ANON, /* private anonymous page and swap of it */ > - MOVE_CHARGE_TYPE_FILE, /* file page(including tmpfs) and swap of it */ > - NR_MOVE_TYPE, > -}; > +#define MOVE_ANON 0x1U > +#define MOVE_FILE 0x2U > +#define MOVE_MASK 0x3U #define MOVE_MASK (MOVE_ANON | MOVE_FILE) would be probably better [...] -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
