On Thu, Jan 29, 2015 at 10:57:38AM +0900, Sergey Senozhatsky wrote: > On Thu, Jan 29, 2015 at 8:33 AM, Minchan Kim <[email protected]> wrote: > > > On Wed, Jan 28, 2015 at 11:56:51PM +0900, Sergey Senozhatsky wrote: > > > I don't like re-introduced ->init_done. > > > another idea... how about using `zram->disksize == 0' instead of > > > `->init_done' (previously `->meta != NULL')? should do the trick. > > > > It could be. > > > > > care to change it?
Will try! > > > > > > > > > > > > and I'm not sure I get this rmb... > > > > What makes you not sure? > > I think it's clear and common pattern for smp_[wmb|rmb]. :) > > > > > well... what that "if (ret)" gives? it's almost always true, because the > device is initialized during read/write operations (in 99.99% of cases). If it was your concern, I'm happy to remove the check.(ie, actually, I realized that after I push the button to send). Thanks! > > -ss -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
