On 01/30/2015 02:12 AM, Andrew Morton wrote: > On Thu, 29 Jan 2015 18:11:50 +0300 Andrey Ryabinin <a.ryabi...@samsung.com> > wrote: > >> Wrap access to object's metadata in external functions with >> metadata_access_enable()/metadata_access_disable() function calls. >> >> This hooks separates payload accesses from metadata accesses >> which might be useful for different checkers (e.g. KASan). >> >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -467,13 +467,23 @@ static int slub_debug; >> static char *slub_debug_slabs; >> static int disable_higher_order_debug; >> >> +static inline void metadata_access_enable(void) >> +{ >> +} >> + >> +static inline void metadata_access_disable(void) >> +{ >> +} > > Some code comments here would be useful. What they do, why they exist, > etc. The next patch fills them in with > kasan_disable_local/kasan_enable_local but that doesn't help the reader > to understand what's going on. The fact that > kasan_disable_local/kasan_enable_local are also undocumented doesn't > help. >
Ok, How about this? /* * This hooks separate payload access from metadata access. * Useful for memory checkers that have to know when slub * accesses metadata. */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/