> Subject: Re: [E1000-devel] [PATCH 1/3] ixgbe, ixgbevf: Add new mbox API to > enable MC promiscuous mode > > On Fri, 2015-01-30 at 11:37 +0000, Hiroshi Shimamoto wrote: > > From: Hiroshi Shimamoto <h-shimam...@ct.jp.nec.com> > > > > The limitation of the number of multicast address for VF is not enough > > for the large scale server with SR-IOV feature. > > IPv6 requires the multicast MAC address for each IP address to handle > > the Neighbor Solicitation message. > > We couldn't assign over 30 IPv6 addresses to a single VF interface. > > > > The easy way to solve this is enabling multicast promiscuous mode. > > It is good to have a functionality to enable multicast promiscuous > > mode > > for each VF from VF driver. > > > > This patch introduces the new mbox API, IXGBE_VF_SET_MC_PROMISC, to > > enable/disable multicast promiscuous mode in VF. If multicast > > promiscuous > > mode is enabled the VF can receive all multicast packets. > > > > With this patch, the ixgbevf driver automatically enable multicast > > promiscuous mode when the number of multicast addresses is over than > > 30 > > if possible. > > > > This also bump the API version up to 1.2 to check whether the API, > > IXGBE_VF_SET_MC_PROMISC is available. > > > > Signed-off-by: Hiroshi Shimamoto <h-shimam...@ct.jp.nec.com> > > Reviewed-by: Hayato Momma <h-mo...@ce.jp.nec.com> > > CC: Choi, Sy Jong <sy.jong.c...@intel.com> > > --- > > drivers/net/ethernet/intel/ixgbe/ixgbe.h | 1 + > > drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 4 + > > drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 89 > > ++++++++++++++++++++++- > > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 13 +++- > > drivers/net/ethernet/intel/ixgbevf/mbx.h | 4 + > > drivers/net/ethernet/intel/ixgbevf/vf.c | 29 +++++++- > > drivers/net/ethernet/intel/ixgbevf/vf.h | 1 + > > 7 files changed, 137 insertions(+), 4 deletions(-) > > Hiroshi, I tried to apply your patches to my queue but they do not apply > cleanly and they are in a DOS file format, not UNIX. I also noted > several checkpatch.pl issues with your patches, so please fix those up > as well.
I'm sorry to bother you. Will fix. > > Can you please fix up your patches based on my tree: > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/queue.git Yes. I haven't noticed your tree. Will resend patches against it. thanks, Hiroshi > > This my queue of all community patches against the Intel LAN drivers and > will be where I queue up your patches while they are under review and > testing.
