On Sat, 9 Jul 2005, Ingo Molnar wrote:
> this patch reduces ip_setsockopt's stack footprint from 572 bytes to 164
> bytes. (Note: needs review and testing as i could not excercise this
> multicast codepath.)
This patch breaks multicast source group joins. Here's the fix:
--- linux.old/net/ipv4/ip_sockglue.c 2005-07-11 01:50:19.000000000 -0700
+++ linux/net/ipv4/ip_sockglue.c 2005-07-11 13:54:34.000000000 -0700
@@ -738,7 +738,7 @@
break;
if (optlen != sizeof(struct group_source_req))
goto free_greqs_e_inval;
- if (copy_from_user(&greqs, optval, sizeof(*greqs))) {
+ if (copy_from_user(greqs, optval, sizeof(*greqs))) {
err = -EFAULT;
goto free_greqs_break;
}
Cheers,
--ww
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
