Re: [PATCH 1/2] sched/wait: add round robin wakeup mode

[Peter Zijlstra]

On Mon, Feb 09, 2015 at 08:05:57PM +0000, Jason Baron wrote:
> diff --git a/kernel/sched/wait.c b/kernel/sched/wait.c
> index 852143a..17d1039 100644
> --- a/kernel/sched/wait.c
> +++ b/kernel/sched/wait.c
> @@ -71,8 +71,11 @@ static void __wake_up_common(wait_queue_head_t *q, 
> unsigned int mode,
>               unsigned flags = curr->flags;
>  
>               if (curr->func(curr, mode, wake_flags, key) &&
> -                             (flags & WQ_FLAG_EXCLUSIVE) && !--nr_exclusive)
> +                            (flags & WQ_FLAG_EXCLUSIVE) && !--nr_exclusive) {
> +                     if (flags & WQ_FLAG_ROUND_ROBIN)
> +                             list_move_tail(&curr->task_list, &q->task_list);
>                       break;
> +             }
>       }
>  }

I think you meant to write something like:

        if (curr->func(curr, mode, wake_flags, key) &&
            (flags & WQ_FLAG_EXCLUSIVE)) {
                if (flag & WQ_FLAG_ROUND_ROBIN)
                        list_move_tail(&curr->task_list, &q->task_list);
                if (!--nr_exclusive)
                        break;
        }

Otherwise can only work for nr_exclusive==1.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/