kfree() checks its argument. It is therefore unnecessary to do this
twice.

This issue was detected using Coccinelle.

Signed-off-by: Bas Peters <baspeter...@gmail.com>
---
 fs/dlm/lockspace.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c
index f3e7278..b660b93 100644
--- a/fs/dlm/lockspace.c
+++ b/fs/dlm/lockspace.c
@@ -674,8 +674,7 @@ static int new_lockspace(const char *name, const char 
*cluster,
  out_lkbidr:
        idr_destroy(&ls->ls_lkbidr);
        for (i = 0; i < DLM_REMOVE_NAMES_MAX; i++) {
-               if (ls->ls_remove_names[i])
-                       kfree(ls->ls_remove_names[i]);
+               kfree(ls->ls_remove_names[i]);
        }
  out_rsbtbl:
        vfree(ls->ls_rsbtbl);
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to