On Sat, Feb 14, 2015 at 11:30:24AM +0100, Wouter Verhelst wrote: > On Thu, Feb 12, 2015 at 09:57:31PM +0100, Markus Pargmann wrote: > > The header is not included anywhere. Remove it and include the private > > nbd_device struct in nbd.c. > > It exists mostly for the benefit of userspace trying to speak the NBD > protocol. I've stopped trying to depend on it (since nbd-server needs to > run on !Linux, too), but there are other implementations that might want > to use it. > > nbd.h is part of a public API. Let's not drop it.
This is just about the kernel internal header include/linux/nbd.h. It is not about the uapi header. I don't want to remove the protocol header. The header this patch is about defines only 'struct nbd_device' which is as far as I can tell only used by nbd.c. Best regards, Markus -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
signature.asc
Description: Digital signature