On February 25, 2015 12:11, Jonathan Cameron wrote:

> > +static int da9150_charger_remove(struct platform_device *pdev)
> > +{
> > +   struct da9150_charger *charger = platform_get_drvdata(pdev);
> > +   int irq;
> > +
> > +   /* Make sure IRQs are released before unregistering power supplies */
> > +   irq = platform_get_irq_byname(pdev, "CHG_VBUS");
> > +   free_irq(irq, charger);
> I'd use your unregister_irq function here as well.  Better than open
> coding the same thing again. (more obviously correct as well as the
> error condition unwinding above then looks just like we have here).

Fair point. Will update that when I start on the additional modules I need to
submit. Thanks.
N�����r��y����b�X��ǧv�^�)޺{.n�+����{����zX����ܨ}���Ơz�&j:+v�������zZ+��+zf���h���~����i���z��w���?�����&�)ߢf��^jǫy�m��@A�a���
0��h���i

Reply via email to