* Arnaldo Carvalho de Melo <[email protected]> wrote:
> From: Andi Kleen <[email protected]>
>
> When cycles or instructions do not print anything, as in being,
> --per-socket or --per-core modi, the ratio column was not correctly
> indented for them. This lead to some ratios not lining up with the
> others. Always indent correctly when nothing is printed.
>
> Signed-off-by: Andi Kleen <[email protected]>
> Link:
> http://lkml.kernel.org/r/[email protected]
> Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
> ---
> tools/perf/builtin-stat.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index e78c68df2152..41b296fff307 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -1093,7 +1093,8 @@ static void abs_printout(int id, int nr, struct
> perf_evsel *evsel, double avg)
> if (total) {
> ratio = avg / total;
> fprintf(output, " # %5.2f insns per cycle ",
> ratio);
> - }
> + } else
> + fprintf(output, " ");
The standard pattern is symmetric curly braces.
> @@ -1162,7 +1163,8 @@ static void abs_printout(int id, int nr, struct
> perf_evsel *evsel, double avg)
> if (total) {
> ratio = avg / total;
> fprintf(output, " # %8.3f GHz ",
> ratio);
> - }
> + } else
> + fprintf(output, " ");
Ditto...
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
