On Mon, Mar 23, 2015 at 12:37 PM, Andy Lutomirski <[email protected]> wrote: > On Mon, Mar 23, 2015 at 9:47 AM, Denys Vlasenko <[email protected]> wrote: >> This vDSO code only gets used by 64-bit kernel, >> not 32-bit. In 64-bit kernels, data segment is the same >> for 32-bit and 64-bit userspace, and SYSRET insn does load %ss >> with its selector. No need to repeat it by hand. Segment loads >> are somewhat expensive: tens of cycles. >> >> Signed-off-by: Denys Vlasenko <[email protected]> >> CC: Linus Torvalds <[email protected]> >> CC: Steven Rostedt <[email protected]> >> CC: Ingo Molnar <[email protected]> >> CC: Borislav Petkov <[email protected]> >> CC: "H. Peter Anvin" <[email protected]> >> CC: Andy Lutomirski <[email protected]> >> CC: Oleg Nesterov <[email protected]> >> CC: Frederic Weisbecker <[email protected]> >> CC: Alexei Starovoitov <[email protected]> >> CC: Will Drewry <[email protected]> >> CC: Kees Cook <[email protected]> >> CC: [email protected] >> CC: [email protected] >> --- >> >> Patch was run-tested. > > Applied, thanks.
Actually, I want to remove the added comment in the code. I don't see why we should have a specific comment about SS and not about, say, CS, ESP, or anything else. OK? > > --Andy -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
