On Mon, Mar 30, 2015 at 10:11:00AM +0200, David Hildenbrand wrote:
> Commit 2e77784bb7d8 ("perf callchain: Move cpumode resolve code to
> add_callchain_ip") promised "No change in behavior.".
> 
> As this commit breaks callchains on s390x (symbols not getting resolved,

I think it's a generic problem not just s390x

the x86 archs were safe due to the (al->map == NULL) fallback
in thread__find_addr_map, where we rerun the lookup for kernel
maps.. I need to rethink this check :-\

perhaps s390x did not match the machine__kernel_ip condition?


> observed when profiling the kernel), this statement is wrong. The cpumode
> must be kept when iterating over all ips, otherwise the default
> (PERF_RECORD_MISC_USER) will be used by error.

anyway

Acked-by: Jiri Olsa <jo...@kernel.org>


thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to