On Tue, Feb 10, 2015 at 10:00:01PM -0600, Han Xu wrote: > On Sun, Feb 1, 2015 at 5:15 AM, Nicholas Mc Guire <hof...@osadl.org> wrote: > > return type of wait_for_completion_timeout is unsigned long not int, this > > patch uses the return value of wait_for_completion_timeout in the condition > > directly rather than adding a additional appropriately typed variable. > > > > Signed-off-by: Nicholas Mc Guire <hof...@osadl.org> > > --- > > > > As the returnvalue of wait_for_completion_timeout is logically treated here > > as a boolean (timeout occured or not) it can be wrapped into the if > > condition > > directly and no additional variable is needed. > > > > This patch was only compile tested with imx_v6_v7_defconfig > > (implies CONFIG_SPI_FSL_QUADSPI=y) > > > > Patch is against 3.19.0-rc6 -next-20150130
In practice, I don't think this should matter, since we're not even close to 2^32 jiffies, but the patch looks fine anyway. Pushed to l2-mtd.git. Thanks! Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
