On Fri, 27 Mar 2015 00:28:02 -0500 Steve French <smfre...@gmail.com> wrote:
> Coverity reports a warning for referencing the beginning of the > SMB2/SMB3 frame using the ProtocolId field as an array. Although > it works the same either way, this patch should quiet the warning > and might be a little clearer. > > Reported by Coverity (CID 741269) > > Signed-off-by: Steve French <smfre...@gmail.com> > --- > fs/cifs/smb2misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/cifs/smb2misc.c b/fs/cifs/smb2misc.c > index 689f035..22dfdf1 100644 > --- a/fs/cifs/smb2misc.c > +++ b/fs/cifs/smb2misc.c > @@ -322,7 +322,7 @@ smb2_get_data_area_len(int *off, int *len, struct > smb2_hdr *hdr) > > /* return pointer to beginning of data area, ie offset from SMB start */ > if ((*off != 0) && (*len != 0)) > - return hdr->ProtocolId + *off; > + return (char *)(&hdr->ProtocolId[0]) + *off; > else > return NULL; > } Acked-by: Jeff Layton <jlay...@poochiereds.net> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
