On Tue 24-03-15 16:47:25, Taesoo Kim wrote:
> Upon successful rename(), update ctime and mtime of new_dir
> as posix specifies.
> 
> Signed-off-by: Taesoo Kim <tsgat...@gmail.com>
  Thanks for spotting the problem! But you apparently didn't test the patch
because it doesn't fix the problem - you've placed the timestamp update
into a wrong branch. Please test the patches before you send them.

I've fixed the problem together with similar issues during file creation,
link, etc.

                                                                Honza

> ---
>  fs/udf/namei.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/udf/namei.c b/fs/udf/namei.c
> index 33b246b..eca1955 100644
> --- a/fs/udf/namei.c
> +++ b/fs/udf/namei.c
> @@ -1144,6 +1144,8 @@ static int udf_rename(struct inode *old_dir, struct 
> dentry *old_dentry,
>                       inode_dec_link_count(new_inode);
>               else {
>                       inc_nlink(new_dir);
> +                     new_dir->i_ctime = new_dir->i_mtime
> +                             = current_fs_time(new_dir->i_sb);
>                       mark_inode_dirty(new_dir);
>               }
>       }
> -- 
> 2.3.3
> 
-- 
Jan Kara <j...@suse.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to