On 01/04/15 10:30, Stas Sergeev wrote: > > Currently fixed_phy uses a callback to periodically poll the link state. > This patch adds the fixed_phy_update_state() API. > It solves the following problems: > - On link state interrupt, MAC driver can't update status. > Instead it needs to provide the callback to periodically query > the HW about the link state. It is more efficient to update status > after interrupt. > - The callback needs to be unregistered before phy_disconnect(), > or otherwise it will be called with net_dev==NULL. phy_disconnect() > does not have enough info to unregister the callback automatically. > - The callback needs to be registered before of_phy_connect() to > avoid running with outdated state, but of_phy_connect() returns the > phy_device pointer, which is needed to register the callback. Registering > it before of_phy_connect() will therefore require a hack to get the > pointer earlier. > > Overall, this addition makes the subsequent patch that implements > SGMII link status for mvneta, much cleaner.
Agreed, now that we have that, we should probably just remove the ability to have a fixed link update callback since it suffers from all the deficiencies you outlined above, and is creating some overhead by polling the hardware. Thanks! -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
