On Sat, 04 Apr 2015 15:09:05 -0500 Tom Zanussi <tom.zanu...@linux.intel.com> wrote:
> > [PATCH] kallsyms: Include module.h > > KSYM_SYMBOL_LEN references MODULE_NAME_LEN, defined in module.h, so > have kallsyms.h include module.h instead of expecting kallsysms users > to do it. > > Also fix up existing kallsyms users that apparently include module.h > for only that reason. > > Signed-off-by: Tom Zanussi <tom.zanu...@linux.intel.com> > --- > include/linux/ftrace.h | 1 - > include/linux/kallsyms.h | 1 + > kernel/trace/trace_events_hist.c | 2 +- > kernel/trace/trace_kprobe.c | 1 + > kernel/trace/trace_output.c | 1 + > kernel/trace/trace_syscalls.c | 2 +- > 6 files changed, 5 insertions(+), 3 deletions(-) Not sure you are proposing this as part of your patch set. I suggest that you don't and post this separately. Also, the removal of kallsyms.h from ftrace.h should be a totally separate patch (along fixing anything that breaks when you remove it, if C files were using ftrace.h to pull in kallsyms.h for them). Then the addition of modules.h to kallsyms.h should be a separate patch. And you should compile the kernel with both a make allmodconfig, make allyesconfig, and then make allyesconfig but disable modules, and see if anything breaks. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
