When building perf with perl or python support it implicitly gets linked with the -export-dynamic linker option through the additional linker flags, namely with -Wl,-E via perl or -Xlinker -export-dynamic via python. That flag is essential for the traceevent plugin support so we shouldn't rely on adding it implicitly.
Ensure perf's exported symbols can be used by dlopen()ed plugins by unconditionally adding this flag when linking perf. Otherwise plugins won't be able to access symbols in the perf binary. This fixes the following warning / bug when trying to load plugins: Warning: could not load plugin '/home/minipli/.traceevent/plugins/plugin_xen.so' /home/minipli/.traceevent/plugins/plugin_xen.so: undefined symbol: trace_seq_printf Warning: could not load plugin '/home/minipli/.traceevent/plugins/plugin_function.so' /home/minipli/.traceevent/plugins/plugin_function.so: undefined symbol: warning Warning: could not load plugin '/home/minipli/.traceevent/plugins/plugin_sched_switch.so' /home/minipli/.traceevent/plugins/plugin_sched_switch.so: undefined symbol: pevent_unregister_event_handler [...] Cc: Arnaldo Carvalho de Melo <a...@kernel.org> Cc: Ingo Molnar <mi...@redhat.com> Cc: Jiri Olsa <jo...@redhat.com> Cc: Paul Mackerras <pau...@samba.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Signed-off-by: Mathias Krause <mini...@googlemail.com> --- This patch should go on top of tip.git#perf/core tools/perf/Makefile.perf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index c43a20517591..2ab8525f366b 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -250,7 +250,8 @@ ifdef ASCIIDOC8 export ASCIIDOC8 endif -LIBS = -Wl,--whole-archive $(PERFLIBS) -Wl,--no-whole-archive -Wl,--start-group $(EXTLIBS) -Wl,--end-group +LIBS = -Wl,--export-dynamic -Wl,--whole-archive $(PERFLIBS) -Wl,--no-whole-archive +LIBS += -Wl,--start-group $(EXTLIBS) -Wl,--end-group export INSTALL SHELL_PATH -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
