On Thursday, April 30, 2015 08:28:56 PM Fabian Frederick wrote: > > > On 30 April 2015 at 06:46 Joe Perches <j...@perches.com> wrote: > > > > > > On Wed, 2015-04-29 at 21:32 +0200, Fabian Frederick wrote: > > > typedef is not really useful here. Replace it by structure > > > to improve readability.typedef should only be used in some cases. > > > (See Documentation/CodingStyle Chapter 5 for details). > > > > trivia: > > > > > diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c > > > b/drivers/cpufreq/pxa2xx-cpufreq.c > > [] > > > @@ -86,7 +86,7 @@ static unsigned int sdram_rows; > > > /* Use the run mode frequencies for the CPUFREQ_POLICY_PERFORMANCE policy > > >*/ > > > #define CCLKCFG CCLKCFG_TURBO | CCLKCFG_FCS > > > > > > -static pxa_freqs_t pxa255_run_freqs[] = > > > +static struct pxa_freqs pxa255_run_freqs[] = > > > > Should these be const? > > AFAICS yes but this needs some fixes: > drivers/cpufreq/pxa2xx-cpufreq.c: In function 'find_freq_tables': > drivers/cpufreq/pxa2xx-cpufreq.c:218:15: warning: assignment discards 'const' > qualifier from pointer target type > *pxa_freqs = pxa255_run_freqs; > ^ > Maybe another patch ?
Yes. One change at a time pretty please. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
